linux-kernel - Re: Re: [PATCH] usb: dwc3: remove dead code in dwc3_otg_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d6dd98f.41e10.187b27043ca.Coremail.lihuya@hust.edu.cn>
Date:   Mon, 24 Apr 2023 16:45:14 +0800 (GMT+08:00)
From:   梁宇航 <lihuya@...t.edu.cn>
To:     "thinh nguyen" <thinh.nguyen@...opsys.com>
Cc:     "greg kroah-hartman" <gregkh@...uxfoundation.org>,
        "dzm91@...t.edu.cn" <dzm91@...t.edu.cn>,
        hust-os-kernel-patches@...glegroups.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] usb: dwc3: remove dead code in dwc3_otg_get_irq

> -----Original Messages-----
> From: "Thinh Nguyen" <Thinh.Nguyen@...opsys.com>
> Sent Time: 2023-03-25 02:28:56 (Saturday)
> To: lihuya <lihuya@...t.edu.cn>
> Cc: "Thinh Nguyen" <Thinh.Nguyen@...opsys.com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "dzm91@...t.edu.cn" <dzm91@...t.edu.cn>, "hust-os-kernel-patches@...glegroups.com" <hust-os-kernel-patches@...glegroups.com>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH] usb: dwc3: remove dead code in dwc3_otg_get_irq
> 
> On Thu, Mar 23, 2023, lihuya wrote:
> > platform_get_irq() only return non-zero irq number on success, or
> > negative error number on failure.
> > 
> > There is no need to check the return value of platform_get_irq()
> > to determine the return value of dwc3_otg_get_irq(), removing
> > them to solve this problem.
> > 
> > Signed-off-by: lihuya <lihuya@...t.edu.cn>
> > ---
> >  drivers/usb/dwc3/drd.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
> > index 039bf241769a..c2e09700212d 100644
> > --- a/drivers/usb/dwc3/drd.c
> > +++ b/drivers/usb/dwc3/drd.c
> > @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc)
> >  		goto out;
> >  
> >  	irq = platform_get_irq(dwc3_pdev, 0);
> > -	if (irq > 0)
> > -		goto out;
> > -
> > -	if (!irq)
> > -		irq = -EINVAL;
> >  
> >  out:
> >  	return irq;
> > -- 
> > 2.34.1
> > 
> 
> Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
> 
> Thanks,
> Thinh

Hi Thinh,

I'm checking in about my patch submission for usb dwc3 that was 
"ack'ed" on 3/25, but hasn't been merged into the subtree yet. 
Could you please provide me with an update on its status and let 
me know if there are any issues or concerns that need to be addressed?