linux-kernel - Re: [PATCH][next] rv: remove redundant assignment to variable retval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <384be1d5-c506-ac40-4302-1d029f1020cb@kernel.org>
Date:   Mon, 24 Apr 2023 11:20:26 +0200
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-trace-devel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH][next] rv: remove redundant assignment to variable retval

On 4/18/23 17:00, Colin Ian King wrote:
> Variable retval is being assigned a value that is never read, it is
> being re-assigned a new value in both paths of a following if statement.
> Remove the assignment.
> 
> Cleans up clang-scan warning:
> kernel/trace/rv/rv.c:293:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
>         retval = count;
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>

Thanks!
-- Daniel