linux-kernel - [PATCH] NTB: remove all the checks of the return values.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2023 09:22:55 +0000
From:   Jintao Huang <u202017189@...t.edu.cn>
To:     Sanjay R Mehta <sanju.mehta@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Jon Mason <jdmason@...zu.us>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <allenbh@...il.com>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Jintao Huang <u202017189@...t.edu.cn>,
        Dongliang Mu <dzm91@...t.edu.cn>, ntb@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: [PATCH] NTB: remove all the checks of the return values.

The comments in debugfs_create_dir and debugfs_create_file point out that,
generally, we do not need to check the return arguments of the functions.
In this case, it will be useful to delete all the checks
about the return arguments.

Signed-off-by: Jintao Huang <u202017189@...t.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
---
This issue is found by static analyzer. The patched code has passed
Smatch checker, but remains untested on concrete running.
---
 drivers/ntb/hw/amd/ntb_hw_amd.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c
index 04550b1f984c..6b0f0c4bf278 100644
--- a/drivers/ntb/hw/amd/ntb_hw_amd.c
+++ b/drivers/ntb/hw/amd/ntb_hw_amd.c
@@ -934,21 +934,13 @@ static ssize_t ndev_debugfs_read(struct file *filp, char __user *ubuf,
 
 static void ndev_init_debugfs(struct amd_ntb_dev *ndev)
 {
-	if (!debugfs_dir) {
-		ndev->debugfs_dir = NULL;
-		ndev->debugfs_info = NULL;
-	} else {
-		ndev->debugfs_dir =
-			debugfs_create_dir(pci_name(ndev->ntb.pdev),
-					   debugfs_dir);
-		if (!ndev->debugfs_dir)
-			ndev->debugfs_info = NULL;
-		else
-			ndev->debugfs_info =
-				debugfs_create_file("info", S_IRUSR,
-						    ndev->debugfs_dir, ndev,
-						    &amd_ntb_debugfs_info);
-	}
+	ndev->debugfs_dir =
+		debugfs_create_dir(pci_name(ndev->ntb.pdev),
+				   debugfs_dir);
+	ndev->debugfs_info =
+		debugfs_create_file("info", 0400,
+				    ndev->debugfs_dir, ndev,
+				    &amd_ntb_debugfs_info);
 }
 
 static void ndev_deinit_debugfs(struct amd_ntb_dev *ndev)
-- 
2.34.1