linux-kernel - Re: [PATCH] firmware: smccc: set variables smccc_soc_id_version,revision storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230424094123.suueva23r4njjbfg@bogus>
Date:   Mon, 24 Apr 2023 10:41:23 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Tom Rix <trix@...hat.com>
Cc:     mark.rutland@....com, lpieralisi@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: smccc: set variables
 smccc_soc_id_version,revision storage-class-specifier to static

On Sun, Apr 23, 2023 at 11:34:28AM -0400, Tom Rix wrote:
> smatch reports
> drivers/firmware/smccc/smccc.c:20:21: warning: symbol
>   'smccc_soc_id_version' was not declared. Should it be static?
> drivers/firmware/smccc/smccc.c:21:21: warning: symbol
>   'smccc_soc_id_revision' was not declared. Should it be static?
> 
> These variables are only used in their defining file so should be static
>

Acked-by: Sudeep Holla <sudeep.holla@....com>

Since the patch introducing this issue comes from irqchip tree, we must
either route this through that if they have earlier fixes set or wait
until v6.4-rc1 and send it through SoC tree. Please cc soc@...nel.org and
Marc Z and repost. It is better to be explicit and mention it is either
based on -next or mention the commit introducing the issue since it make
no sense if one has no knowledge of -next change.

-- 
Regards,
Sudeep