linux-kernel - Re: [PATCH] rv: Fix addition on an uninitialized variable 'run'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9396dbe-08aa-620c-cb08-7ea9943e1561@gmail.com>
Date:   Mon, 24 Apr 2023 10:45:41 +0100
From:   "Colin King (gmail)" <colin.i.king@...il.com>
To:     Daniel Bristot de Oliveira <bristot@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-trace-devel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rv: Fix addition on an uninitialized variable 'run'

On 24/04/2023 10:44, Colin Ian King wrote:
> The variable run is not initialized however it is being accumulated
> by the return value from the call to ikm_run_monitor.  Fix this by
> initializing run to zero at the start of the function.
> 
> Fixes: 4bc4b131d44c ("rv: Add rv tool")
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   tools/verification/rv/src/rv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/verification/rv/src/rv.c b/tools/verification/rv/src/rv.c
> index e601cd9c411e..1ddb85532816 100644
> --- a/tools/verification/rv/src/rv.c
> +++ b/tools/verification/rv/src/rv.c
> @@ -74,7 +74,7 @@ static void rv_list(int argc, char **argv)
>   static void rv_mon(int argc, char **argv)
>   {
>   	char *monitor_name;
> -	int i, run;
> +	int i, run = 0;
>   
>   	static const char *const usage[] = {
>   		"",

Oops, I forgot the V2, will re-send as a V3. My bad.