linux-kernel - Re: [PATCH v1 1/3] dt-bindings: iio: light: ROHM BU27008

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06d60a20-a620-b9f6-adc3-337973dfb8a8@linaro.org>
Date:   Mon, 24 Apr 2023 12:12:59 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Matti Vaittinen <mazziesaccount@...il.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: iio: light: ROHM BU27008

On 21/04/2023 11:38, Matti Vaittinen wrote:
> The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear
> and IR) with four configurable channels. Red and green being always
> available and two out of the rest three (blue, clear, IR) can be
> selected to be simultaneously measured. Typical application is adjusting
> LCD backlight of TVs, mobile phones and tablet PCs.
> 
> Add BU27008 dt-bindings.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> ---
>  .../bindings/iio/light/rohm-bu27008.yaml      | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml

Filename like compatible, so rohm,bu27008.yaml

> 
> diff --git a/Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml b/Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml
> new file mode 100644
> index 000000000000..d942c2817680
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/bu27008.yaml#

Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).


> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BU27008 color sensor
> +
> +maintainers:
> +  - Matti Vaittinen <mazziesaccount@...il.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear
> +  and IR) with four configurable channels. Red and green being always
> +  available and two out of the rest three (blue, clear, IR) can be
> +  selected to be simultaneously measured. Typical application is adjusting
> +  LCD backlight of TVs, mobile phones and tablet PCs.


Best regards,
Krzysztof