linux-kernel - Re: [PATCH v2 0/2] selftests/ftrace: Add tests for kprobes and optimized probes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1682334408.u49nhd1gk9.naveen@linux.ibm.com>
Date:   Mon, 24 Apr 2023 16:39:56 +0530
From:   "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
To:     Akanksha J N <akanksha@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Cc:     mhiramat@...nel.org, rostedt@...dmis.org, shuah@...nel.org
Subject: Re: [PATCH v2 0/2] selftests/ftrace: Add tests for kprobes and
 optimized probes

Akanksha J N wrote:
> This patchset adds a stress test for kprobes and a test for checking
> optimized probes.
> The two tests are being added based on the below discussion:
> https://lore.kernel.org/all/20230128101622.ce6f8e64d929e29d36b08b73@kernel.org/
> 
> Changelog:
> 
> 
> * Add an explicit fork after enabling the events ( echo "forked" )
> * Remove the extended test from multiple_kprobe_types.tc which adds 
>   multiple consecutive probes in a function and add it as a 
>   separate test case. 
> * Add new test case which checks for optimized probes.
> 
> Akanksha J N (2):
>   selftests/ftrace: Add new test case which adds multiple consecutive
>     probes in a function
>   selftests/ftrace: Add new test case which checks for optimized probes
> 
>  .../test.d/kprobe/kprobe_insn_boundary.tc     | 19 +++++++++++
>  .../ftrace/test.d/kprobe/kprobe_opt_types.tc  | 34 +++++++++++++++++++
>  2 files changed, 53 insertions(+)
>  create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_insn_boundary.tc
>  create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc

This series looks good to me.
Acked-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>



- Naveen