linux-kernel - Re: [PATCH] drivers: regulator: core: remove return value check of `rdev->debugfs`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b1dcfd3-a82c-5165-7c0a-1767f97273e6@hust.edu.cn>
Date:   Mon, 24 Apr 2023 20:17:09 +0800
From:   Dongliang Mu <dzm91@...t.edu.cn>
To:     Mark Brown <broonie@...nel.org>,
        Yuchen Yang <u202114568@...t.edu.cn>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        hust-os-kernel-patches@...glegroups.com,
        Liam Girdwood <lrg@...mlogic.co.uk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: regulator: core: remove return value check of
 `rdev->debugfs`


On 2023/4/24 19:56, Mark Brown wrote:
> On Mon, Apr 24, 2023 at 10:57:37AM +0800, Yuchen Yang wrote:
>> Smatch complains that:
>> rdev_init_debugfs() warn: 'rdev->debugfs' is an error pointer or valid
>>
>> According to the documentation of the debugfs_create_dir() function,
>> there is no need to check the return value of this function.
>> Just delete the dead code.
> Please stop sending these patches.

No problem. We will disable this Smatch checker in our daily use.

Thanks for your feedback.