linux-kernel - Re: [PATCH] spi: remove return value check of debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2023 14:53:12 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Peter Enderborg <peter.enderborg@...y.com>,
        Yingsha Xu <ysxu@...t.edu.cn>,
        Serge Semin <fancer.lancer@...il.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()

On Mon, Apr 24, 2023 at 01:32:14PM +0100, Mark Brown wrote:
> On Mon, Apr 24, 2023 at 02:20:45PM +0200, Peter Enderborg wrote:
> > On 4/24/23 13:54, Mark Brown wrote:
> 
> > > This is very much a question of taste with a range of use cases
> > > available.
> 
> > No. 
> > https://lkml.iu.edu/hypermail/linux/kernel/1901.2/05993.html

Please use lore.kernel.org links in the future.

> > We can do things with the debug information without filesystem enabled.

What exactly do you mean by this?

> There's issues with partially created debugfs structures getting in the
> way of people trying to debug things, just completely ignoring all
> errors can create confusion as the diagnostic information people believe
> is being shown to them ends up being partial or mistructured without any
> indication that this has happened.

How do you end up with partially created debugfs structures?

thanks,

greg k-h