linux-kernel - Re: [PATCH] usb: typec: mux: Remove some unneeded includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEZ+aPo3Ccq64l4+@kuha.fi.intel.com>
Date:   Mon, 24 Apr 2023 16:04:40 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: typec: mux: Remove some unneeded includes

On Mon, Apr 24, 2023 at 10:39:56AM +0200, Christophe JAILLET wrote:
> This driver includes many header files that are unneeded.
> Remove them and add <linux/device.h> where devm_kzalloc() is defined.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
> Based on one of my script, this reduces the number of included files
> during the build process of this file from 551 to 345.
> ---
>  drivers/usb/typec/mux/gpio-sbu-mux.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
> index f62516dafe8f..c07856069d43 100644
> --- a/drivers/usb/typec/mux/gpio-sbu-mux.c
> +++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
> @@ -3,14 +3,11 @@
>   * Copyright (C) 2022 Linaro Ltd.
>   */
>  
> -#include <linux/bits.h>
> -#include <linux/i2c.h>
> -#include <linux/kernel.h>
> +#include <linux/device.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/platform_device.h>
> -#include <linux/regmap.h>
>  #include <linux/usb/typec_dp.h>
>  #include <linux/usb/typec_mux.h>
>  
> -- 
> 2.34.1

-- 
heikki