linux-kernel - Re: [PATCH] spi: remove return value check of debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2023 15:08:03 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Peter Enderborg <peter.enderborg@...y.com>,
        Yingsha Xu <ysxu@...t.edu.cn>,
        Serge Semin <fancer.lancer@...il.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()

On Mon, Apr 24, 2023 at 02:00:14PM +0100, Mark Brown wrote:
> On Mon, Apr 24, 2023 at 02:53:12PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Apr 24, 2023 at 01:32:14PM +0100, Mark Brown wrote:
> 
> > > There's issues with partially created debugfs structures getting in the
> > > way of people trying to debug things, just completely ignoring all
> > > errors can create confusion as the diagnostic information people believe
> > > is being shown to them ends up being partial or mistructured without any
> > > indication that this has happened.
> 
> > How do you end up with partially created debugfs structures?
> 
> The ones I've seen have been name collisions caused by for example the
> debugfs structure created being flatter than the device model structure,
> though obviously something unanticipated could come up.

Sure name collisions will happen, when people aren't precise about how
they create their debugfs files (I just had to insist on this type of
fixups for a USB patch last week.)  But, debugfs failures should never
stop a driver from working properly, only the debugging functionalities.
So there's no need to error out from debugfs errors as the only one
affected is the kernel developer involved, not users.

thanks,

greg k-h