linux-kernel - Re: [PATCH] ntb: hw: intel: remove return value check of `ndev_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9479d2e4-8147-aee2-3a2b-1cd06a4ad4e0@intel.com>
Date:   Mon, 24 Apr 2023 08:33:46 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Yinhao Hu <dddddd@...t.edu.cn>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>, ntb@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ntb: hw: intel: remove return value check of
 `ndev_init_debugfs`



On 4/22/23 8:56 AM, Yinhao Hu wrote:
> Smatch complains that:
> ndev_init_debugfs() warn: 'ndev->debugfs_dir' is an error pointer or valid
> 
> Debugfs checks are generally not supposed to be checked for errors
> and it is not necessary here.

Can you please provide source on where this is true?

> 
> Just delete the dead code.
> 
> Signed-off-by: Yinhao Hu <dddddd@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---
> The issue is found by static analysis and remains untested.
> ---
>   drivers/ntb/hw/intel/ntb_hw_gen1.c | 11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> index 9ab836d0d4f1..9b0b2c43f1bb 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> @@ -778,13 +778,10 @@ static void ndev_init_debugfs(struct intel_ntb_dev *ndev)
>   		ndev->debugfs_dir =
>   			debugfs_create_dir(pci_name(ndev->ntb.pdev),
>   					   debugfs_dir);
> -		if (!ndev->debugfs_dir)
> -			ndev->debugfs_info = NULL;
> -		else
> -			ndev->debugfs_info =
> -				debugfs_create_file("info", S_IRUSR,
> -						    ndev->debugfs_dir, ndev,
> -						    &intel_ntb_debugfs_info);
> +		ndev->debugfs_info =
> +			debugfs_create_file("info", S_IRUSR,
> +					    ndev->debugfs_dir, ndev,
> +					    &intel_ntb_debugfs_info);
>   	}
>   }
>