linux-kernel - Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed846afc-7155-4998-9a8d-e9d9e8aaf8e2@sirena.org.uk>
Date:   Mon, 24 Apr 2023 16:52:25 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Li Ningke <lnk_01@...t.edu.cn>,
        hust-os-kernel-patches@...glegroups.com, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`

On Mon, Apr 24, 2023 at 08:03:42PM +0800, Dongliang Mu wrote:
> On 2023/4/24 19:48, Mark Brown wrote:

> > Is that check valid?  0 was a valid interrupt for some architectures...

> We just follow the comments of platform_get_irq().

>  * Gets an IRQ for a platform device and prints an error message if finding
> the
>  * IRQ fails. Device drivers should check the return value for errors so as
> to
>  * not pass a negative integer value to the request_irq() APIs.

I'm not sure that's universally true yet, though there were some moves
to try to get us there.  arm, where this driver is used, was one of the
platforms with 0 as a valid interrupt.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)