linux-kernel - Re: [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b3342d5-8407-49af-b4c8-b54d350be7a2@paulmck-laptop>
Date:   Mon, 24 Apr 2023 11:35:03 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     SeongJae Park <sj@...nel.org>, akpm@...ux-foundation.org,
        willy@...radead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mm/slab: add a missing semicolon on
 SLAB_TYPESAFE_BY_RCU example code

On Mon, Apr 24, 2023 at 08:27:45PM +0200, Vlastimil Babka wrote:
> On 4/24/23 19:43, Paul E. McKenney wrote:
> > On Sat, Apr 15, 2023 at 03:31:58AM +0000, SeongJae Park wrote:
> >> An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon.
> >> Add it.
> >>
> >> Signed-off-by: SeongJae Park <sj@...nel.org>
> > 
> > Reviewed-by: Paul E. McKenney <paulmck@...nel.org>
> > 
> > Or please let me know if you would like me to take it.  (Probably better
> > going up through the usual slab route, though.)
> 
> Yeah will take it via slab after merge window, but was hoping you'd ack
> that (mainly 2/2) as indeed the correct example first.

You got it!  ;-)

							Thanx, Paul

> Thanks, Vlastimil
> 
> > 							Thanx, Paul
> > 
> >> ---
> >>  include/linux/slab.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/linux/slab.h b/include/linux/slab.h
> >> index f8b1d63c63a3..b18e56c6f06c 100644
> >> --- a/include/linux/slab.h
> >> +++ b/include/linux/slab.h
> >> @@ -53,7 +53,7 @@
> >>   * stays valid, the trick to using this is relying on an independent
> >>   * object validation pass. Something like:
> >>   *
> >> - *  rcu_read_lock()
> >> + *  rcu_read_lock();
> >>   * again:
> >>   *  obj = lockless_lookup(key);
> >>   *  if (obj) {
> >> -- 
> >> 2.25.1
> >>