linux-kernel - Re: [PATCH v2] usb: phy: phy-tahvo: fix memory leak in tahvo_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2023 07:15:39 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     ktestrobot@....com, U201911841@...t.edu.cn
Cc:     lidaxian@...t.edu.cn, hust-os-kernel-patches@...glegroups.com,
        dzm91@...t.edu.cn, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, balbi@...nel.org, s.shtylyov@....ru
Subject: Re: [PATCH v2] usb: phy: phy-tahvo: fix memory leak in
 tahvo_usb_probe()

On Tue, Apr 25, 2023 at 10:58:51AM +0800, ktestrobot@....com wrote:
> Hi, Li Yang
> This email is automatically replied by KTestRobot(Beta). Please do not reply to this email.

But I will!

> If you have any questions or suggestions about KTestRobot, please contact ZhongYong <U201911841@...t.edu.cn>

First question, why are you responding from an email that is not allowed
to be responded to and forced to have us manually add an address?
That's not very nice or helpful for us who have to see these messages,
please fix that.

> --- Changed Paths ---
> drivers/usb/phy/phy-tahvo.c
> --- Log Message ---
> Smatch reports:
> drivers/usb/phy/phy-tahvo.c: tahvo_usb_probe()
> warn: missing unwind goto?
> 
> After geting irq, if ret < 0, it will return without error handling to
> free memory.
> Just add error handling to fix this problem.
> 
> --- Test Result ---
> *** CheckPatch	PASS ***
> *** CheckSmatch	PASS ***
> *** ApplyToLinuxNext	PASS ***

Why is only "does the patch apply" matter for this bot?  What is it
supposed to be doing here?  Is it going to run on every single patch to
this mailing list, and if so, how can we turn it off as "it applied!" is
a very very low bar to be testing something for, and we already have a
bot that does this.

thanks,

greg k-h