linux-kernel - Re: [PATCH for-next v2 0/3] RDMA/rtrs: bugfix and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2023 01:03:51 +0000
From:   "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To:     "haris.iqbal@...os.com" <haris.iqbal@...os.com>,
        "jinpu.wang@...os.com" <jinpu.wang@...os.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC:     "guoqing.jiang@...ux.dev" <guoqing.jiang@...ux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for-next v2 0/3] RDMA/rtrs: bugfix and cleanups

Jack, Guoqing


Thank you all for the reviewing and testing, I will post a new version soon.



On 23/04/2023 09:26, Li Zhijian wrote:
> V2:
> - Add new patch2 to fix a memory leak
> - rewrite original patch2 to patch3 by refactoring the cleanup path instead of
>    introducing a new flag
> - Drop original patch3: RDMA/rtrs: Fix use-after-free in rtrs_clt_rdma_cm_handler
>    The problem it tried to addressing doesn't appear after the new patch3Jack
>    where it adjust the cleanup order
> 
> It's trying to fix 1 issue triggered by the following script which
> connect/disconnect rnbd frequently.
> 
> # cat rnbd-self.sh
> #!/bin/bash
> 
> /root/rpma/tools/config_softroce.sh eth0
> modprobe rnbd_server
> modprobe rnbd_client
> 
> while true;
> do
>          echo "sessname=xyz path=ip:<server-ip> device_path=/dev/nvme0n1" > /sys/devices/virtual/rnbd-client/ctl/map_device
>          for i in /sys/block/rnbd*/rnbd/unmap_device
>          do
>                  echo "normal" > $i
>          done
> done
> 
> Li Zhijian (3):
>    RDMA/rtrs: remove duplicate cq_num assignment
>    RDMA/rtrs: Fix the last iu->buf leak in err path
>    RDMA/rtrs: Fix rxe_dealloc_pd warning
> 
>   drivers/infiniband/ulp/rtrs/rtrs-clt.c | 56 +++++++++++---------------
>   drivers/infiniband/ulp/rtrs/rtrs.c     |  4 +-
>   2 files changed, 26 insertions(+), 34 deletions(-)
>