linux-kernel - Re: [PATCH] coresight: perf: Release Coresight path when alloc trace id failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2023 10:14:44 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Ruidong Tian <tianruidong@...ux.alibaba.com>,
        coresight@...ts.linaro.org
Cc:     mike.leach@...aro.org, leo.yan@...aro.org,
        alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: perf: Release Coresight path when alloc trace
 id failed

On 25/04/2023 04:24, Ruidong Tian wrote:
> Error handler for etm_setup_aux can not release coresight path because
> cpu mask was cleared when coresight_trace_id_get_cpu_id failed.
> 
> Call coresight_release_path function explicitly when alloc trace id filed.
> 
> Signed-off-by: Ruidong Tian <tianruidong@...ux.alibaba.com>

Good catch, I will queue this.

Thanks
Suzuki

> ---
>   drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 711f451b6946..89e8ed214ea4 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -402,6 +402,7 @@ static void *etm_setup_aux(struct perf_event *event, void **pages,
>   		trace_id = coresight_trace_id_get_cpu_id(cpu);
>   		if (!IS_VALID_CS_TRACE_ID(trace_id)) {
>   			cpumask_clear_cpu(cpu, mask);
> +			coresight_release_path(path);
>   			continue;
>   		}
>