linux-kernel - [PATCH RFC v2 2/6] media: v4l2-ctrls: clarify documentation of V4L2_CID_FOCUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230406-feature-controls-lens-v2-2-faa8ad2bc404@wolfvision.net>
Date:   Tue, 25 Apr 2023 11:45:12 +0200
From:   Michael Riesch <michael.riesch@...fvision.net>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     libcamera-devel@...ts.libcamera.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Matthias Fend <Matthias.Fend@...fvision.net>,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michael Riesch <michael.riesch@...fvision.net>
Subject: [PATCH RFC v2 2/6] media: v4l2-ctrls: clarify documentation of
 V4L2_CID_FOCUS_RELATIVE

The control V4L2_CID_FOCUS_RELATIVE only makes sense if the device cannot
handle absolute focal point positioning with V4L2_CID_FOCUS_ABSOLUTE.
Clarify this in the documentation.

Signed-off-by: Michael Riesch <michael.riesch@...fvision.net>
---
 Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
index df29150dce7b..42cf4c3cda0c 100644
--- a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
+++ b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
@@ -147,7 +147,9 @@ enum v4l2_exposure_metering -
     This control moves the focal point of the camera by the specified
     amount. The unit is undefined. Positive values move the focus closer
     to the camera, negative values towards infinity. This is a
-    write-only control.
+    write-only control. It should be implemented only if the device cannot
+    handle absolute values.
+
 
 ``V4L2_CID_FOCUS_AUTO (boolean)``
     Enables continuous automatic focus adjustments. The effect of manual

-- 
2.37.2