linux-kernel - Re: [PATCH 4/5] Glue code for optmized Poly1305 implementation for ppc64le.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2023 06:58:07 -0500
From:   Danny Tsen <dtsen@...ux.ibm.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     linux-crypto@...r.kernel.org, leitao@...ian.org,
        nayna@...ux.ibm.com, appro@...ptogams.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        mpe@...erman.id.au, ltcgcw@...ux.vnet.ibm.com, dtsen@...ibm.com
Subject: Re: [PATCH 4/5] Glue code for optmized Poly1305 implementation for
 ppc64le.

Did not notice that.  Will do fix it.

Thanks.

-Danny

On 4/25/23 12:44 AM, Herbert Xu wrote:
> On Mon, Apr 24, 2023 at 02:47:25PM -0400, Danny Tsen wrote:
>> +	if (likely(srclen >= POLY1305_BLOCK_SIZE)) {
>> +		bytes = round_down(srclen, POLY1305_BLOCK_SIZE);
>> +		used = crypto_poly1305_setdctxkey(dctx, src, bytes);
>> +		if (likely(used)) {
>> +			srclen -= used;
>> +			src += used;
>> +		}
>> +		if (srclen >= POLY1305_BLOCK_SIZE*4) {
>> +			vsx_begin();
> Your chacha code has a SIMD-fallback, how come this one doesn't?
>
> Thanks,