linux-kernel - Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230425-filtrate-nearby-f62515de1ec1@wendy>
Date:   Tue, 25 Apr 2023 13:02:02 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Hal Feng <hal.feng@...rfivetech.com>
CC:     <linux-clk@...r.kernel.org>, <oe-kbuild-all@...ts.linux.dev>,
        <linux-mm@...ck.org>, Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Paul Gazzillo <paul@...zz.com>,
        Necip Fazil Yildiran <fazilyildiran@...il.com>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>,
        Xingyu Wu <xingyu.wu@...rfivetech.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be
 selected in a specified case

On Tue, Apr 25, 2023 at 07:53:04PM +0800, Hal Feng wrote:
> On Tue, 18 Apr 2023 20:37:56 +0800, Hal Feng wrote:
> > When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]),
> > RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS
> > and CLK_STARFIVE_JH7110_AON.
> > 
> > Add a condition `if RESET_CONTROLLER` to fix it. Also, delete redundant
> > selected options of CLK_STARFIVE_JH7110_AON because these options are
> > already selected by the dependency.
> > 
> > Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver")
> > Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver")
> > Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
> 
> Hi, Stephen,
> 
> Could this patch be merged into v6.4? Thanks.

Whoops, I thought I had replied to this a week ago. In case it helps,
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> 
> Best regards,
> Hal
> 
> > ---
> >  drivers/clk/starfive/Kconfig | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig
> > index 71c1148ee5f6..5d2333106f13 100644
> > --- a/drivers/clk/starfive/Kconfig
> > +++ b/drivers/clk/starfive/Kconfig
> > @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS
> >  	depends on ARCH_STARFIVE || COMPILE_TEST
> >  	select AUXILIARY_BUS
> >  	select CLK_STARFIVE_JH71X0
> > -	select RESET_STARFIVE_JH7110
> > +	select RESET_STARFIVE_JH7110 if RESET_CONTROLLER
> >  	default ARCH_STARFIVE
> >  	help
> >  	  Say yes here to support the system clock controller on the
> > @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS
> >  config CLK_STARFIVE_JH7110_AON
> >  	tristate "StarFive JH7110 always-on clock support"
> >  	depends on CLK_STARFIVE_JH7110_SYS
> > -	select AUXILIARY_BUS
> > -	select CLK_STARFIVE_JH71X0
> > -	select RESET_STARFIVE_JH7110
> >  	default m if ARCH_STARFIVE
> >  	help
> >  	  Say yes here to support the always-on clock controller on the
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)