linux-kernel - Re: [PATCH v10 02/14] HP BIOSCFG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOOmCE8AkvXmD=RJLS_R1z+fmuzt1HSSr9DwnS8=pA4Wtjx7mA@mail.gmail.com>
Date:   Tue, 25 Apr 2023 08:43:18 -0500
From:   Jorge Lopez <jorgealtxwork@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Pavel Machek <pavel@....cz>, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas@...ch.de
Subject: Re: [PATCH v10 02/14] HP BIOSCFG driver - biosattr-interface

On Tue, Apr 25, 2023 at 5:31 AM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 4/21/23 13:37, Pavel Machek wrote:
> > Hi!
> >
> >> Linux Security components are under development and not published yet.
> >> The only linux component is the driver (hp bioscfg) at this time.
> >> Other published security components are under Windows.
> >>
> >> Signed-off-by: Jorge Lopez <jorge.lopez2@...com>
> >
> >> +/*
> >> + * ascii_to_utf16_unicode -  Convert ascii string to UTF-16 unicode
> >> + *
> >> + * BIOS supports UTF-16 characters that are 2 bytes long.  No variable
> >> + * multi-byte language supported.
> >> + *
> >> + * @p:   Unicode buffer address
> >> + * @str: string to convert to unicode
> >> + *
> >> + * Returns a void pointer to the buffer containing unicode string
> >> + */
> >> +void *ascii_to_utf16_unicode(u16 *p, const u8 *str)
> >> +{
> >
> > Does this need to go to library somewhere?
>
> This has already been discussed in earlier submissions
> of the driver, the utf16 format is HP specific (prefixed
> with a 16 bit le lenght, and the 0 length string needs
> special encoding) so despite the name this is not generic.
>
> It should probably be prefixed with hp_ because of this
> though, to avoid potential symbol conflicts when builtin.
>
> (and the same applies to other generic functions).

I will add the prefix 'hp_' to those generic functions such
ascii_to_utf16_unicode.

>
> Regards,
>
> Hans
>
>