linux-kernel - Re: [PATCH v3 00/65] clk: Make determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3nwpjtfa46zorfpuvvugximqe5qmovff76dqphoxbndr6mczcc@ndau7cegfxb2>
Date:   Tue, 25 Apr 2023 16:46:47 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Abel Vesa <abelvesa@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Andreas Färber <afaerber@...e.de>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...il.com>,
        David Lechner <david@...hnology.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jaroslav Kysela <perex@...ex.cz>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Max Filippov <jcmvbkbc@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        NXP Linux Team <linux-imx@....com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Samuel Holland <samuel@...lland.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sekhar Nori <nsekhar@...com>, Shawn Guo <shawnguo@...nel.org>,
        Takashi Iwai <tiwai@...e.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Vinod Koul <vkoul@...nel.org>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-actions@...ts.infradead.org, patches@...nsource.cirrus.com,
        linux-stm32@...md-mailman.stormreply.com,
        linux-mediatek@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org, linux-tegra@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-phy@...ts.infradead.org,
        linux-rtc@...r.kernel.org, linux-sunxi@...ts.linux.dev,
        alsa-devel@...a-project.org, linux-mips@...r.kernel.org,
        Liam Beguin <liambeguin@...il.com>
Subject: Re: [PATCH v3 00/65] clk: Make determine_rate mandatory for muxes

On Thu, Apr 13, 2023 at 02:44:51PM -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2023-04-04 03:10:50)
> > Hi,
> > 
> > This is a follow-up to a previous series that was printing a warning
> > when a mux has a set_parent implementation but is missing
> > determine_rate().
> > 
> > The rationale is that set_parent() is very likely to be useful when
> > changing the rate, but it's determine_rate() that takes the parenting
> > decision. If we're missing it, then the current parent is always going
> > to be used, and thus set_parent() will not be used. The only exception
> > being a direct call to clk_set_parent(), but those are fairly rare
> > compared to clk_set_rate().
> > 
> > Stephen then asked to promote the warning to an error, and to fix up all
> > the muxes that are in that situation first. So here it is :)
> > 
> 
> Thanks for resending.
> 
> I was thinking that we apply this patch first and then set
> determine_rate clk_ops without setting the clk flag. The function name
> is up for debate.

Ack, I'll send a new version following your proposal

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)