linux-kernel - Re: [PATCH] mei: make hdcp and pxp depend on X86 && PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230425152720.GA4155584@angband.pl>
Date:   Tue, 25 Apr 2023 17:27:20 +0200
From:   Adam Borowski <kilobyte@...band.pl>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>
Subject: Re: [PATCH] mei: make hdcp and pxp depend on X86 && PCI

On Tue, Apr 25, 2023 at 03:40:10PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 25, 2023 at 01:52:10PM +0200, Adam Borowski wrote:
> > On Tue, Apr 25, 2023 at 04:39:23AM +0000, Winkler, Tomas wrote:
> > > What is the exact issue you are experiencing, can you add the error message this fixes? 
> > 
> > The problem doesn't trigger in mainline
> 
> Then it's nothing we need to worry about in mainline.  If/when other
> changes ever happen to need it here in mainline, we will gladly take the
> change.
> 
> For obvious reasons, we can't take patches for issues outside of our
> codebase.  Nor do you want us to, as that way lies madness and an
> unmaintainable mess.

The problem in mainline is inconsistency: out of 6 config items, 4 repeat
the "depends on X86 && PCI" line, the other 2 do not.  There's indeed no
immediate functional issue, but I'd argue that a dormant bug is still a bug.

So we can fix the cosmetic (currently) issue on its own, or as part of the
large patchset -- the latter having a side effect of stuffing your mailboxes
more than needed (neither Greg, Arnd, nor Tomas are involved in other bits).

But do the selects really require so much duplication?  Perhaps I'm trying
to fix the underlying issue wrong? 


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Only flat-earthers have a problem folding a fitted sheet.
⢿⡄⠘⠷⠚⠋⠀ I instead shape it into a ball.
⠈⠳⣄⠀⠀⠀⠀