linux-kernel - Re: [PATCH] scsi: ipr: remove several unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1wn20k638.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 24 Apr 2023 23:12:52 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Tom Rix <trix@...hat.com>
Cc:     brking@...ibm.com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        john.g.garry@...cle.com, dlemoal@...nel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ipr: remove several unused variables


Tom,

> gcc with W=1 reports
> drivers/scsi/ipr.c: In function ‘ipr_init_res_entry’:
> drivers/scsi/ipr.c:1104:22: error: variable ‘proto’
>   set but not used [-Werror=unused-but-set-variable]
>  1104 |         unsigned int proto;
>       |                      ^~~~~
> drivers/scsi/ipr.c: In function ‘ipr_update_res_entry’:
> drivers/scsi/ipr.c:1261:22: error: variable ‘proto’
>   set but not used [-Werror=unused-but-set-variable]
>  1261 |         unsigned int proto;
>       |                      ^~~~~
> drivers/scsi/ipr.c: In function ‘ipr_change_queue_depth’:
> drivers/scsi/ipr.c:4417:36: error: variable ‘res’
>   set but not used [-Werror=unused-but-set-variable]
>  4417 |         struct ipr_resource_entry *res;
>       |                                    ^~~
>
> These variables are not used, so remove them.
> The lock around res is not needed so remove that.
> Which makes ioa_cfg and lock_flags unneeded so remove them.

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering