linux-kernel - Re: [PATCH v1] trace: add the necessary dependencies of configuration options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230425150236.005e2e8b@gandalf.local.home>
Date:   Tue, 25 Apr 2023 15:02:36 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     sunying@...iscas.ac.cn
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v1] trace: add the necessary dependencies of
 configuration options

On Fri, 14 Apr 2023 16:27:56 +0800
sunying@...iscas.ac.cn wrote:

> From: Ying Sun <sunying@...iscas.ac.cn>
> 
> HAVE_NOP_MCOUNT is used only if the condition
> "ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile,
> adding a dependency constraint on this configuration option
>  to prevent it from being set ‘y' but not taking effect.
> 
> Suggested-by: Yanjie Ren <renyanjie01@...il.com>
> Signed-off-by: Ying Sun <sunying@...iscas.ac.cn>
> ---
>  kernel/trace/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 8cf97fa4a4b3..c640f405cc91 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -77,6 +77,7 @@ config HAVE_FENTRY
>  
>  config HAVE_NOP_MCOUNT
>  	bool
> +	depends on FTRACE_MCOUNT_USE_CC

As I replied to the other email. The HAVE_* configs are only for
architectures to say if they support something or not. There's no need to
add dependencies here.

-- Steve



>  	help
>  	  Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount
>