linux-kernel - Re: [PATCH] rust: Sort rust/helpers.c's #include directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kXa-SgRiVhvjU7X4fa8XSJB4po9xf_V4L6Gn2o+t6T+Q@mail.gmail.com>
Date:   Tue, 25 Apr 2023 22:37:57 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Ariel Miculas <ariel.miculas@...il.com>
Cc:     rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com,
        boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
        benno.lossin@...ton.me, Ariel Miculas <amiculas@...co.com>
Subject: Re: [PATCH] rust: Sort rust/helpers.c's #include directives

Hi Ariel,

On Tue, Apr 25, 2023 at 10:28 PM Ariel Miculas <ariel.miculas@...il.com> wrote:
>
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@...co.com>

First of all, thanks for the patch!

These tags look OK, but if you want to attribute the patches to your
Cisco address, could you please send them from that address?

Also, the commit description is missing. In the kernel, we give the
rationale for a change and describe what the patch does for every
commit.

Please take a look at `Documentation/process/submitting-patches.rst`
and try `scripts/checkpatch.pl` -- it can point some issues like this.

> +/*
> + * Sorted alphabetically.
> + */

Please join this comment with the top one, i.e. please do not open a
new /* */ block, like it is done in the other file mentioned in the
linked issue.

Cheers,
Miguel