linux-kernel - Re: [PATCH v2] libbpf: Improve version handling when attaching uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07e05c57-feb7-5482-9c07-eb41f976f9fd@meta.com>
Date:   Wed, 26 Apr 2023 14:47:27 -0700
From:   Yonghong Song <yhs@...a.com>
To:     Espen Grindhaug <espen.grindhaug@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2] libbpf: Improve version handling when attaching uprobe



On 4/23/23 11:55 AM, Espen Grindhaug wrote:
> This change fixes the handling of versions in elf_find_func_offset.
> In the previous implementation, we incorrectly assumed that the

Could you give more explanation/example in the commit message
what does 'incorrectly' mean here? In which situations the
current libbpf implementation will not be correct?

> version information would be present in the string found in the
> string table.
> 
> We now look up the correct version string in the version symbol
> table before constructing the full name and then comparing.
> 
> This patch adds support for both name@...sion and name@@version to
> match output of the various elf parsers.
> 
> Signed-off-by: Espen Grindhaug <espen.grindhaug@...il.com>

[...]