linux-kernel - Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpF88Xu_Xf3w5oM4xRmXphwGjMaLhusEHV7gtAFNXXnP2A@mail.gmail.com>
Date:   Tue, 25 Apr 2023 22:08:24 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Yang Yang <yang.yang29@....com.cn>
Cc:     mingo@...hat.com, hannes@...xchg.org, juri.lelli@...hat.com,
        linux-kernel@...r.kernel.org, peterz@...radead.org
Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min
 update period when destroy trigger

On Tue, Apr 25, 2023 at 8:32 PM Yang Yang <yang.yang29@....com.cn> wrote:
>
> > On Mon, Apr 17, 2023 at 1:12 AM <yang.yang29@....com.cn> wrote:
> >>
> >> From: Yang Yang <yang.yang19@....com.cn>
> >>
> >> Psi_group's poll_min_period is determined by the min window size of
> >> psi_trigger when creating new triggers. While destroying a psi_trigger,
> >> there is no need to reset poll_min_period if the destroying psi_trigger
> >> not had the min windows size, since in this condition poll_min_period
> >> will keep the same as before.
> >
> > Nice optimization.
> >
> >>
> >> Signed-off-by: Yang Yang <yang.yang29@....com.cn>
> >
> > Acked-by: Suren Baghdasaryan <surenb@...gle.com>
>
> Hi, would you please take a review?

I guess this is a ping for PeterZ to queue this patch in his tree.
Peter, any issues with accepting this patch?

> Thanks!