linux-kernel - Re: [PATCH 1/2] watchdog: dw_wdt: Fix the error handling path of dw_wdt_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230426073243.GA4724@pengutronix.de>
Date:   Wed, 26 Apr 2023 09:32:43 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Steffen Trumtrar <s.trumtrar@...gutronix.de>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Wim Van Sebroeck <wim@...ana.be>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 1/2] watchdog: dw_wdt: Fix the error handling path of
 dw_wdt_drv_probe()

Hi Christophe,

On Wed, Apr 26, 2023 at 08:52:48AM +0200, Christophe JAILLET wrote:
> The commit in Fixes has only updated the remove function and missed the
> error handling path of the probe.
> 
> Add the missing reset_control_assert() call.
> 
> Fixes: 65a3b6935d92 ("watchdog: dw_wdt: get reset lines from dt")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp