linux-kernel - Re: [PATCH v6 4/4] crypto: starfive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67846b76-1ade-c253-e50b-1c0a0dd0a84a@wanadoo.fr>
Date:   Wed, 26 Apr 2023 10:09:50 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     jiajie.ho@...rfivetech.com
Cc:     davem@...emloft.net, devicetree@...r.kernel.org,
        herbert@...dor.apana.org.au, kernel@...il.dk,
        krzysztof.kozlowski+dt@...aro.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        palmer@...belt.com, robh+dt@...nel.org
Subject: Re: [PATCH v6 4/4] crypto: starfive - Add hash and HMAC support

Le 26/04/2023 à 08:58, Jia Jie Ho a écrit :
> Adding hash/HMAC support for SHA-2 and SM3 to StarFive cryptographic
> module.
> 
> Co-developed-by: Huan Feng <huan.feng-bONrM45KWFOXmMXjJBpWqg@...lic.gmane.org>
> Signed-off-by: Huan Feng <huan.feng-bONrM45KWFOXmMXjJBpWqg@...lic.gmane.org>
> Signed-off-by: Jia Jie Ho <jiajie.ho-bONrM45KWFOXmMXjJBpWqg@...lic.gmane.org>
> ---
>   drivers/crypto/starfive/Kconfig       |   4 +
>   drivers/crypto/starfive/Makefile      |   2 +-
>   drivers/crypto/starfive/jh7110-cryp.c |  38 ++
>   drivers/crypto/starfive/jh7110-cryp.h |  70 +-
>   drivers/crypto/starfive/jh7110-hash.c | 896 ++++++++++++++++++++++++++
>   5 files changed, 1006 insertions(+), 4 deletions(-)
>   create mode 100644 drivers/crypto/starfive/jh7110-hash.c
> 

[...]

> +int starfive_hash_register_algs(void)
> +{
> +	int ret = 0;
> +
> +	ret = crypto_register_ahashes(algs_sha2_sm3, ARRAY_SIZE(algs_sha2_sm3));
> +
> +	return ret;

Nit: return crypto_register_ahashes(algs_sha2_sm3, 
ARRAY_SIZE(algs_sha2_sm3));

?

> +}
> +
> +void starfive_hash_unregister_algs(void)
> +{
> +	crypto_unregister_ahashes(algs_sha2_sm3, ARRAY_SIZE(algs_sha2_sm3));
> +}