[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230426111004.56tq4rzbnndxrsnf@skbuf>
Date: Wed, 26 Apr 2023 14:10:04 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Harini Katakam <harini.katakam@....com>
Cc: robh+dt@...nel.org, andrew@...n.ch, hkallweit1@...il.com,
linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
edumazet@...gle.com, pabeni@...hat.com,
wsa+renesas@...g-engineering.com,
krzysztof.kozlowski+dt@...aro.org, simon.horman@...igine.com,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, harinikatakamlinux@...il.com,
michal.simek@....com, radhey.shyam.pandey@....com
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: mscc: Add RGMII RX and TX
delay tuning
On Wed, Apr 26, 2023 at 04:13:12PM +0530, Harini Katakam wrote:
> From: Harini Katakam <harini.katakam@...inx.com>
>
> Add optional properties to tune RGMII RX and TX delay. The current
> default value in the Linux driver, when the phy-mode is rgmii-id,
> is 2ns for both. These properties take priority if specified.
>
> Signed-off-by: Harini Katakam <harini.katakam@....com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> v2:
> - Updated DT binding description and commit for optional delay tuning
> to be clearer on the precedence
> - Updated dt property name to include vendor instead of phy device name
>
> Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 0a3647fe331b..2b779bc3096b 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -33,6 +33,8 @@ Optional properties:
> VSC8531_DUPLEX_COLLISION (8).
> - load-save-gpios : GPIO used for the load/save operation of the PTP
> hardware clock (PHC).
> +- mscc,rx-delay : RGMII RX delay. Allowed values are 0.2 - 3.4 ns.
> +- mscc,tx-delay : RGMII TX delay. Allowed values are 0.2 - 3.4 ns.
We have rx-internal-delay-ps and tx-internal-delay-ps in the common
ethernet-phy.yaml, there is no need for a custom property.
Powered by blists - more mailing lists