linux-kernel - Re: [PATCH] regmap: REGMAP_KUNIT must not select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2023 15:34:27 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     David Gow <davidgow@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: REGMAP_KUNIT must not select REGMAP

Hi Mark,

On Wed, Apr 26, 2023 at 2:42 PM Mark Brown <broonie@...nel.org> wrote:
> On Wed, Apr 26, 2023 at 01:56:44PM +0200, Geert Uytterhoeven wrote:
> > Enabling a (modular) test must not silently enable additional kernel
> > functionality, as that may increase the attack vector of a product.
> >
> > Fix this by making REGMAP_KUNIT depend on REGMAP instead.
>
> This doesn't work since regmap is a selected library so there's no way
> to directly enable regmap other than by enabling something that uses it
> and it is very likely that the virtual configurations people often use
> with KUnit will not have any physical hardware and therefore will not
> need regmap.  It seems a lot more likely that someone would want to run
> the tests on a platform that doesn't otherwise use regmap than that
> someone would end up building in regmap on a production kernel that
> wouldn't otherwise have enabled it.

Thanks, I had missed that.  Will send a v2...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds