linux-kernel - Re: [PATCH v3 (repost)] locking/lockdep: add debug_show_all_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a11a2d1e-c74f-c6a2-fa8f-c5a06aa9ce4d@I-love.SAKURA.ne.jp>
Date:   Wed, 26 Apr 2023 22:43:57 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>
Cc:     Waiman Long <longman@...hat.com>, Will Deacon <will@...nel.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Hillf Danton <hdanton@...a.com>
Subject: Re: [PATCH v3 (repost)] locking/lockdep: add
 debug_show_all_lock_holders()

Ingo or Peter, can we make progress on this patch?
Linus wants this patch be handled by locking people, if this patch is acceptable.

https://lkml.kernel.org/r/CAHk-=wjbu9USn=hVWQ9v9t1H+8R6qXj8REkm36==w10zM0cM6g@mail.gmail.com

On 2023/04/04 18:01, Hillf Danton wrote:
>> When check_hung_uninterruptible_tasks() reports a thread waiting for a
>> lock, it is important to report backtrace of threads which already held
>> that lock. Therefore, allow check_hung_uninterruptible_tasks() to report
>> the exact location of threads which is holding any lock.
> 
> Yeah more info should have been printed for udevd/5109 to help work out
> the cause of task hung [1].
> 
> [1] https://lore.kernel.org/lkml/000000000000ac91f005f5eec2e5@google.com/
>>
>> debug_show_all_lock_holders() skips current thread if the caller is
>> holding no lock, for reporting RCU lock taken inside that function is
>> generally useless.
>>
>> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
>> ---
> 
> Acked-by: Hillf Danton <hdanton@...a.com>
> 
>> I couldn't catch Peter's question at
>> https://lkml.kernel.org/r/Y+oY3Xd43nNnkDSB@hirez.programming.kicks-ass.net .
>> I consider that this patch as-is is helpful, for not all TASK_RUNNING threads
>> are actually running on some CPU, aren't they? If we show backtrace of only
>> TASK_RUNNING threads which are running on some CPU, we fail to get hints for
>> TASK_RUNNING threads which are not running on some CPU. Therefore, I consider
>> that showing backtrace of TASK_RUNNING threads which are not running on some
>> CPU is better than not showing.