linux-kernel - Re: [PATCH] kbuild: deb-pkg: specify targets in debian/rules as .PHONY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARyW56E=RC_23NuEr7ZYi-iuxo6CvKfrPcCxJXcAF3ngg@mail.gmail.com>
Date:   Wed, 26 Apr 2023 23:12:29 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>
Subject: Re: [PATCH] kbuild: deb-pkg: specify targets in debian/rules as .PHONY

On Wed, Apr 26, 2023 at 3:08 AM Nathan Chancellor <nathan@...nel.org> wrote:
>
> On Tue, Apr 25, 2023 at 08:08:59PM +0900, Masahiro Yamada wrote:
> > If a file with the same name exists, the target is not run.
> >
> > For example, the following command fails.
> >
> >   $ make O=build-arch bindeb-pkg
> >     [ snip ]
> >   sed: can't read modules.order: No such file or directory
> >   make[6]: *** [../Makefile:1577: __modinst_pre] Error 2
> >   make[5]: *** [../scripts/Makefile.package:150: intdeb-pkg] Error 2
> >   make[4]: *** [../Makefile:1657: intdeb-pkg] Error 2
> >   make[3]: *** [debian/rules:14: binary-arch] Error 2
> >   dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> >   make[2]: *** [../scripts/Makefile.package:139: bindeb-pkg] Error 2
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>

Applied to linux-kbuild.



>
> > ---
> >
> >  scripts/package/mkdebian | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> > index a4c2c2276223..b6cb95473548 100755
> > --- a/scripts/package/mkdebian
> > +++ b/scripts/package/mkdebian
> > @@ -269,6 +269,8 @@ cat <<EOF > debian/rules
> >  srctree ?= .
> >  KERNELRELEASE = ${KERNELRELEASE}
> >
> > +.PHONY: clean build build-arch build-indep binary binary-arch binary-indep
> > +
> >  build-indep:
> >  build-arch:
> >       \$(MAKE) -f \$(srctree)/Makefile ARCH=${ARCH} \
> > --
> > 2.37.2
> >



-- 
Best Regards
Masahiro Yamada