linux-kernel - Re: [PATCH v3 0/2] Hwmon driver for MAX31827 temperature switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2023 07:38:56 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Matyas <daniel.matyas@...log.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Hwmon driver for MAX31827 temperature switch

On 4/26/23 05:40, Daniel Matyas wrote:
> Removed of_match_table and kept only id_table. Removed other device id's
> from id_table (I have them only in the devicetree-binding).
> 

Please explain. Without of_match_table, it is not possible to bind the driver
using devicetree data. What is the point of that ?

Guenter

> Added mutex protection where it was needed.
> 
> Daniel Matyas (2):
>    dt-bindings: hwmon: add MAX31827
>    hwmon: max31827: add MAX31827 driver
> 
>   .../bindings/hwmon/adi,max31827.yaml          |  54 +++
>   Documentation/hwmon/index.rst                 |   1 +
>   Documentation/hwmon/max31827.rst              |  83 ++++
>   MAINTAINERS                                   |   9 +
>   drivers/hwmon/Kconfig                         |  11 +
>   drivers/hwmon/Makefile                        |   2 +-
>   drivers/hwmon/max31827.c                      | 406 ++++++++++++++++++
>   7 files changed, 565 insertions(+), 1 deletion(-)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
>   create mode 100644 Documentation/hwmon/max31827.rst
>   create mode 100644 drivers/hwmon/max31827.c
>