linux-kernel - Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4cdd1cd2-bf9a-ed55-946d-48f917f72342@hust.edu.cn>
Date:   Wed, 26 Apr 2023 23:07:12 +0800
From:   Dongliang Mu <dzm91@...t.edu.cn>
To:     Mark Brown <broonie@...nel.org>
Cc:     Li Ningke <lnk_01@...t.edu.cn>,
        hust-os-kernel-patches@...glegroups.com, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`


On 2023/4/26 22:13, Mark Brown wrote:
> On Wed, Apr 26, 2023 at 09:50:26AM +0800, Dongliang Mu wrote:
>
>> Second, from code review of platform_get_irq / platform_get_irq_optional, it
>> would warn IRQ 0 as an invalid IRQ number.
>> out:
>> 	if (WARN(!ret, "0 is an invalid IRQ number\n"))
>> 		return -EINVAL;
>> 	return ret;
> Like I say I'm not sure that's actually accurate for all architectures
> yet.

I see. Let's wait and see. When it becomes stable and universal for all 
architectures, we could clean up them all together.

Currently our team just works to make Smatch happy :)