linux-kernel - RE: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR11MB54443013C3378D4D5992033BE5659@CH0PR11MB5444.namprd11.prod.outlook.com>
Date:   Wed, 26 Apr 2023 15:31:13 +0000
From:   "Cavitt, Jonathan" <jonathan.cavitt@...el.com>
To:     "Hajda, Andrzej" <andrzej.hajda@...el.com>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Auld, Matthew" <matthew.auld@...el.com>
Subject: RE: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL

-----Original Message-----
From: Hajda, Andrzej <andrzej.hajda@...el.com> 
Sent: Wednesday, April 26, 2023 8:14 AM
To: intel-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Cavitt, Jonathan <jonathan.cavitt@...el.com>; Hajda, Andrzej <andrzej.hajda@...el.com>; Auld, Matthew <matthew.auld@...el.com>
Subject: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL
>
>This patchset patches sent by Jonathan and Andi, with 
>addressed CI failures:
>1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12.
>2. Fixed start alignment of 2M pages.
>
>Regards
>Andrzej
>
>Jonathan Cavitt (2):
>  drm/i915: Migrate platform-dependent mock hugepage selftests to live
>  drm/i915: Use correct huge page manager for MTL
>
>.../gpu/drm/i915/gem/selftests/huge_pages.c   | 88 +++++++++++++++----
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  3 +-
> 2 files changed, 71 insertions(+), 20 deletions(-)
>
>Cc: intel-gfx@...ts.freedesktop.org
>Cc: linux-kernel@...r.kernel.org
>Cc: Jonathan Cavitt <jonathan.cavitt@...el.com>
>Cc: Andrzej Hajda <andrzej.hajda@...el.com>
>Cc: Matthew Auld <matthew.auld@...el.com>
>-- 
>2.39.2
>
>---
>Jonathan Cavitt (2):
>      drm/i915: Migrate platform-dependent mock hugepage selftests to live
>      drm/i915: Use correct huge page manager for MTL
>
> drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 105 ++++++++++++++++++------
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c            |   3 +-
> 2 files changed, 82 insertions(+), 26 deletions(-)
>---
>base-commit: 4d0066a1c0763d50b6fb017e27d12b081ce21b57
>change-id: 20230425-hugepage-migrate-1869aaf31a6d
>
>Best regards,
>-- 
>Andrzej Hajda <andrzej.hajda@...el.com>


Just reviewed the changes proper.  It's been a while, so I don't remember everything
about the prior version, but I think I recognized what was changed:

- I wasn't aware a 21 bit alignment was required for 2M page sizes.  I'm glad you caught that.
- The extra debugging/error information will be helpful in the case of a failure.
- Grabbing the per-context VM instead of the ppgtt vm sounds good to me.

Everything here looks amenable.
Acked-by: Jonathan Cavitt <jonathan.cavitt@...el.com>
Though, given I'm also one of the signed-off-bys, I don't know if me acking it is exactly above-board.
-Jonathan Cavitt


>