linux-kernel - Re: [PATCH] drm/amd/display: set variable custom_backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2023 13:15:12 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Tom Rix <trix@...hat.com>, harry.wentland@....com,
        sunpeng.li@....com, Rodrigo.Siqueira@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        qingqing.zhuo@....com, Josip.Pavic@....com, robin.chen@....com,
        alex.hung@....com, dingchen.zhang@....com,
        jiapeng.chong@...ux.alibaba.com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: set variable custom_backlight_curve0
 storage-class-specifier to static

On 4/26/23 07:18, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31:
>    warning: symbol 'custom_backlight_curve0' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> index 68d95b92df76..30349881a283 100644
> --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> @@ -116,7 +116,7 @@ static const struct abm_parameters * const abm_settings[] = {
>   	abm_settings_config2,
>   };
>   
> -const struct dm_bl_data_point custom_backlight_curve0[] = {
> +static const struct dm_bl_data_point custom_backlight_curve0[] = {
>   		{2, 14}, {4, 16}, {6, 18}, {8, 21}, {10, 23}, {12, 26}, {14, 29}, {16, 32}, {18, 35},
>   		{20, 38}, {22, 41}, {24, 44}, {26, 48}, {28, 52}, {30, 55}, {32, 59}, {34, 62},
>   		{36, 67}, {38, 71}, {40, 75}, {42, 80}, {44, 84}, {46, 88}, {48, 93}, {50, 98},
-- 
Hamza