linux-kernel - Re: [net v2] net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61ea49b7-8a04-214d-ef02-3ef6181619e9@arinc9.com>
Date:   Wed, 26 Apr 2023 20:25:47 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Frank Wunderlich <linux@...web.de>,
        linux-mediatek@...ts.infradead.org
Cc:     Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        stable@...r.kernel.org, Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [net v2] net: ethernet: mtk_eth_soc: drop generic vlan rx
 offload, only use DSA untagging

On 26/04/2023 20:21, Frank Wunderlich wrote:
> From: Felix Fietkau <nbd@....name>
> 
> Through testing I found out that hardware vlan rx offload support seems to
> have some hardware issues. At least when using multiple MACs and when
> receiving tagged packets on the secondary MAC, the hardware can sometimes
> start to emit wrong tags on the first MAC as well.
> 
> In order to avoid such issues, drop the feature configuration and use
> the offload feature only for DSA hardware untagging on MT7621/MT7622
> devices where this feature works properly.
> 
> Fixes: 08666cbb7dd5 ("net: ethernet: mtk_eth_soc: add support for configuring vlan rx offload")
> Tested-by: Frank Wunderlich <frank-w@...lic-files.de>
> Signed-off-by: Felix Fietkau <nbd@....name>
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> Tested-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
> v2:
> - changed commit message to drop "only one MAC used" phrase based on
>    Arincs comments
> - fixed too long line in commit description and add empty line after
>    declaration
> - add fixes tag
> 
> used felix Patch as base and ported up to 6.3-rc6
> 
> it basicly reverts changes from vladimirs patch
> 
> 1a3245fe0cf8 net: ethernet: mtk_eth_soc: fix DSA TX tag hwaccel for switch port 0
> 
> tested this on bananapi-r3 on non-dsa gmac1 and dsa eth0 (wan).
> on both vlan is working, but maybe it breaks HW-vlan-untagging

I'm confused by this. What is HW-vlan-untagging, and which SoCs do you 
think this patch would break this feature? How can I utilise this 
feature on Linux so I can confirm whether it works or not?

Arınç