[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230426-engine-pueblo-9967197ace5a-mkl@pengutronix.de>
Date: Wed, 26 Apr 2023 19:47:28 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: "Mendez, Judith" <jm@...com>
Cc: Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
Wolfgang Grandegger <wg@...ndegger.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-can@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Schuyler Patton <spatton@...com>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH v2 1/4] can: m_can: Add hrtimer to generate software
interrupt
On 26.04.2023 11:11:12, Mendez, Judith wrote:
[...]
> > print a proper error message using dev_err_probe("IRQ %s not found and
> > polling not activated\n")
> >
> Why %s when MCAN requests 1 IRQ which is "int0"? If we want to print "int0",
> should it be hardcoded into the print error message?
I think I copied the error message from platform_get_irq_byname() and
extended it. Of course it makes sense to hardcode the IRQ name.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists