[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9f8f082d-7bc7-2271-9b6c-cd7bf96c755b@arinc9.com>
Date: Wed, 26 Apr 2023 20:51:22 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Frank Wunderlich <frank-w@...lic-files.de>
Cc: Frank Wunderlich <linux@...web.de>,
linux-mediatek@...ts.infradead.org, Felix Fietkau <nbd@....name>,
John Crispin <john@...ozen.org>,
Sean Wang <sean.wang@...iatek.com>,
Mark Lee <Mark-MC.Lee@...iatek.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
stable@...r.kernel.org
Subject: Re: Aw: Re: [net v2] net: ethernet: mtk_eth_soc: drop generic vlan rx
offload, only use DSA untagging
On 26/04/2023 20:31, Frank Wunderlich wrote:
>
>> Gesendet: Mittwoch, 26. April 2023 um 19:25 Uhr
>> Von: "Arınç ÜNAL" <arinc.unal@...nc9.com>
>> On 26/04/2023 20:21, Frank Wunderlich wrote:
>>> From: Felix Fietkau <nbd@....name>
>>>
>>> Through testing I found out that hardware vlan rx offload support seems to
>>> have some hardware issues. At least when using multiple MACs and when
>>> receiving tagged packets on the secondary MAC, the hardware can sometimes
>>> start to emit wrong tags on the first MAC as well.
>>>
>>> In order to avoid such issues, drop the feature configuration and use
>>> the offload feature only for DSA hardware untagging on MT7621/MT7622
>>> devices where this feature works properly.
>>>
>>> Fixes: 08666cbb7dd5 ("net: ethernet: mtk_eth_soc: add support for configuring vlan rx offload")
>>> Tested-by: Frank Wunderlich <frank-w@...lic-files.de>
>>> Signed-off-by: Felix Fietkau <nbd@....name>
>>> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>>> Tested-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>>
>> I'm confused by this. What is HW-vlan-untagging, and which SoCs do you
>> think this patch would break this feature? How can I utilise this
>> feature on Linux so I can confirm whether it works or not?
>
> the feature itself breaks vlan on mac of bpi-r3
>
> 1 mac is connected to switch and uses dsa tags, the other mac is directly accessible and vlan-tag
> there is stripped by this feature.
>
> with this patch i can use vlans on the "standalone" mac again (see tagged packets incoming).
Ok, since this patch is disabling the feature, the patch cannot possibly
break the feature. That's why I was confused as to why you mentioned
this in a way that gives the impression that this patch may break the
said feature.
Anyhow:
Acked-by: Arınç ÜNAL <arinc.unal@...nc9.com>
Arınç
Powered by blists - more mailing lists