linux-kernel - Re: [PATCH v3] vringh: IOMEM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEl5yKYzsw/g+tQh@corigine.com>
Date:   Wed, 26 Apr 2023 21:21:44 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Shunsuke Mie <mie@...l.co.jp>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] vringh: IOMEM support

On Tue, Apr 25, 2023 at 07:22:50PM +0900, Shunsuke Mie wrote:
> Introduce a new memory accessor for vringh. It is able to use vringh to
> virtio rings located on io-memory region.
> 
> Signed-off-by: Shunsuke Mie <mie@...l.co.jp>

...

Hi Mie-san,

thanks for your patch.
One small nit from me below.

> diff --git a/include/linux/vringh.h b/include/linux/vringh.h
> index c3a8117dabe8..c03d045f7f3f 100644
> --- a/include/linux/vringh.h
> +++ b/include/linux/vringh.h
> @@ -330,4 +330,37 @@ int vringh_need_notify_iotlb(struct vringh *vrh);
>  
>  #endif /* CONFIG_VHOST_IOTLB */
>  
> +#if IS_REACHABLE(CONFIG_VHOST_RING_IOMEM)
> +
> +int vringh_init_iomem(struct vringh *vrh, u64 features,
> +		      unsigned int num, bool weak_barriers,
> +		      struct vring_desc *desc,
> +		      struct vring_avail *avail,
> +		      struct vring_used *used);
> +
> +

nit: one blank line is enough.

> +int vringh_getdesc_iomem(struct vringh *vrh,
> +			 struct vringh_kiov *riov,
> +			 struct vringh_kiov *wiov,
> +			 u16 *head,
> +			 gfp_t gfp);

...