linux-kernel - Re: [PATCH v1 1/1] net/ncsi: Fix the multi thread manner of NCSI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEl+sL5TMmOaqZNa@corigine.com>
Date:   Wed, 26 Apr 2023 21:42:40 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Cc:     patrick@...cx.xyz, Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] net/ncsi: Fix the multi thread manner of NCSI
 driver

On Mon, Apr 24, 2023 at 07:47:42PM +0800, Delphine CC Chiu wrote:
> From: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> 
> Currently NCSI driver will send several NCSI commands back
> to back without waiting the response of previous NCSI command
> or timeout in some state when NIC have multi channel. This
> operation against the single thread manner defined by NCSI
> SPEC(section 6.3.2.3 in DSP0222_1.1.1).
> 
> 1. Fix the problem of NCSI driver that sending command back
> to back without waiting the response of previos NCSI command

Hi Delphine,

a minor nit from my side: s/previos/previous/

> or timeout to meet the single thread manner.
> 2. According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1),
> we should probe one channel at a time by sending NCSI commands
> (Clear initial state, Get version ID, Get capabilities...), than
> repeat this steps until the max number of channels which we got
> from NCSI command (Get capabilities) has been probed.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>