linux-kernel - Re: [PATCH v3] rust: helpers: sort includes alphabetically in rust/helpers.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b8e3c30-9626-dffd-0aff-4b5c650154ad@gmail.com>
Date:   Wed, 26 Apr 2023 17:55:25 -0300
From:   Martin Rodriguez Reboredo <yakoyoku@...il.com>
To:     Ariel Miculas <amiculas@...co.com>, rust-for-linux@...r.kernel.org,
        linux-kernel@...r.kernel.org, ojeda@...nel.org,
        alex.gaynor@...il.com, wedsonaf@...il.com, boqun.feng@...il.com,
        gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me
Subject: Re: [PATCH v3] rust: helpers: sort includes alphabetically in
 rust/helpers.c

On 4/26/23 17:49, Ariel Miculas wrote:
> Sort the #include directives of rust/helpers.c alphabetically and add a
> comment specifying this. The reason for this is to improve readability
> and to be consistent with the other files with a similar approach within
> 'rust/'.
> 
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@...co.com>
> ---
> [...]
Shouldn't the link use the `Link: <url> [1]` format? Otherwise LGTM.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>