linux-kernel - Re: [PATCH] hwmon: (oxp-sensors) Add AYANEO 2 and Geek models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABgtM3i+HZJDearvBK-sBrWnfqdrsuNCDYfxASC3QVsn8rAy-Q@mail.gmail.com>
Date:   Thu, 27 Apr 2023 20:16:05 -0300
From:   Joaquin Aramendia <samsagax@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     derekjohn.clark@...il.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add AYANEO 2 and Geek models

Hello Guenter and thanks for your quick review.

> Please run checkpatch --strict on your patches. Never mind, I'll apply the
> patch anyway - I see the other entries are the same.
I've run it before on the other patches... did something change in the
checkpatch?
Nevermid, After this one I may submit a patch to fix all styling in one go

> That makes me have a closer look at the code. What is the purpose of the
> odd typecast anyway ? Why not just
>         .driver_data = (void *)aya_neo_2,
> and
>         board = (enum oxp_board)dmi_entry->driver_data;
> ?
I don't know why but the compiler would complain with the casting from
enum to void*.
Found out that explicitly casting the enum literal before casting it
to void* works and
the compiler stopped complaining so I went with it.

As a follow up question, since this driver has become more AYANEO than
OXP since its inception,
 wouldn't  it be better to change the description?

Joaquín Aramendía