linux-kernel - Re: [RFC PATCH v3 35/37] tools: Add FUSE, update bpf includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYD9P+1aP+q77i7RJPJW=iSS6-iTw+rfPuCz=FFB2MiZw@mail.gmail.com>
Date:   Wed, 26 Apr 2023 21:24:37 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Daniel Rosenberg <drosen@...gle.com>
Cc:     Miklos Szeredi <miklos@...redi.hu>, bpf@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Amir Goldstein <amir73il@...il.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-unionfs@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Joanne Koong <joannelkoong@...il.com>,
        Mykola Lysenko <mykolal@...com>, kernel-team@...roid.com
Subject: Re: [RFC PATCH v3 35/37] tools: Add FUSE, update bpf includes

On Mon, Apr 17, 2023 at 6:42 PM Daniel Rosenberg <drosen@...gle.com> wrote:
>
> Updates the bpf includes under tools, and adds fuse
>
> Signed-off-by: Daniel Rosenberg <drosen@...gle.com>
> ---
>  tools/include/uapi/linux/bpf.h  |   12 +
>  tools/include/uapi/linux/fuse.h | 1135 +++++++++++++++++++++++++++++++
>  2 files changed, 1147 insertions(+)
>  create mode 100644 tools/include/uapi/linux/fuse.h
>
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 4b20a7269bee..6521c40875c7 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -7155,4 +7155,16 @@ struct bpf_iter_num {
>         __u64 __opaque[1];
>  } __attribute__((aligned(8)));
>
> +/* Return Codes for Fuse BPF struct_op programs */
> +#define BPF_FUSE_CONTINUE              0
> +#define BPF_FUSE_USER                  1
> +#define BPF_FUSE_USER_PREFILTER                2
> +#define BPF_FUSE_POSTFILTER            3
> +#define BPF_FUSE_USER_POSTFILTER       4

nit: can this be an enum instead? It would be more self-documenting,
IMO. At given it's FUSE BPF-specific, why is it not in
uapi/linux/fuse.h?

> +
> +/* Op Code Filter values for BPF Programs */
> +#define FUSE_OPCODE_FILTER     0x0ffff
> +#define FUSE_PREFILTER         0x10000
> +#define FUSE_POSTFILTER                0x20000
> +

[...]