linux-kernel - Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ed28be7-7bb5-acc5-c955-f4cf238ffc49@quicinc.com>
Date:   Thu, 27 Apr 2023 14:23:16 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <linus.walleij@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <richardcochran@...il.com>, <manivannan.sadhasivam@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver


On 4/26/2023 10:12 PM, Andy Shevchenko wrote:
> On Wed, Apr 26, 2023 at 6:18 PM Rohit Agarwal <quic_rohiagar@...cinc.com> wrote:
>> On 4/26/2023 8:34 PM, andy.shevchenko@...il.com wrote:
>>> Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti:
> ...
>
>>>> +#define FUNCTION(fname)                                                     \
>>>> +    [msm_mux_##fname] = {                                           \
>>>> +            .name = #fname,                                         \
>>>> +            .groups = fname##_groups,                               \
>>>> +    .ngroups = ARRAY_SIZE(fname##_groups),                          \
>>>> +    }
>>> PINCTRL_PINFUNCTION() ?
>> Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?
> Yes, please.
PINCTRL_PINGROUP cannot be used as it is, since msm_pigroup has multiple 
other fields that needs to be set
for each pingroup defined.
Would rename this to SDX75_PINGROUP, as seen on some other platforms.
Would that be ok?

Thanks,
Rohit.
>