linux-kernel - Re: [PATCH v1] watchdog: starfive: Fix the warning of starfive_wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd96b2d6-69df-01e0-9784-5dfaddd28711@roeck-us.net>
Date:   Thu, 27 Apr 2023 02:48:08 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Xingyu Wu <xingyu.wu@...rfivetech.com>,
        linux-watchdog@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     Samin Guo <samin.guo@...rfivetech.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] watchdog: starfive: Fix the warning of
 starfive_wdt_match

On 4/27/23 00:44, Xingyu Wu wrote:
> Drop the function of of_match_ptr() to fix the warning of unused variable
> 'starfive_wdt_match'.
> 
> Fixes: db728ea9c7be ("drivers: watchdog: Add StarFive Watchdog driver")
> Signed-off-by: Xingyu Wu <xingyu.wu@...rfivetech.com>
> ---

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> 
> Hi, Guenter and Wim,
> 
> This patch fixes the compiler warning of StarFive watchdog driver and
> rebases on the master branch of linux-next.
> 
> Thanks.
> 
> ---
>   drivers/watchdog/starfive-wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/starfive-wdt.c b/drivers/watchdog/starfive-wdt.c
> index 1995cceca51e..64d1ad4d267a 100644
> --- a/drivers/watchdog/starfive-wdt.c
> +++ b/drivers/watchdog/starfive-wdt.c
> @@ -595,7 +595,7 @@ static struct platform_driver starfive_wdt_driver = {
>   	.driver = {
>   		.name = "starfive-wdt",
>   		.pm = &starfive_wdt_pm_ops,
> -		.of_match_table = of_match_ptr(starfive_wdt_match),
> +		.of_match_table = starfive_wdt_match,
>   	},
>   };
>   module_platform_driver(starfive_wdt_driver);