linux-kernel - Re: [PATCH] drm/meson: set variables meson_hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2023 14:52:38 +0200
From:   neil.armstrong@...aro.org
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Tom Rix <trix@...hat.com>
Cc:     airlied@...il.com, daniel@...ll.ch, khilman@...libre.com,
        jbrunet@...libre.com, dri-devel@...ts.freedesktop.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/meson: set variables meson_hdmi_*
 storage-class-specifier to static

On 23/04/2023 23:36, Martin Blumenstingl wrote:
> On Sun, Apr 23, 2023 at 4:53 PM Tom Rix <trix@...hat.com> wrote:
>>
>> smatch has several simailar warnings to
> s/simailar/similar/
> 
>> drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol
>>    'meson_hdmi_enci_mode_480i' was not declared. Should it be static?
>>
>> These variables are only used in their defining file so should be static
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
> With above typo fixed (or with a comment from the maintainers that
> they can fix it while applying):
> Acked-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Thanks, fixed while applying.

Neil