linux-kernel - RE: [PATCH v3 0/2] wifi: rtw88: error codes fix patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5629deb196114fefb12f5f2273b4786d@realtek.com>
Date:   Thu, 27 Apr 2023 00:47:07 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Zhang Shurong <zhang_shurong@...mail.com>
CC:     "tony0620emma@...il.com" <tony0620emma@...il.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 0/2] wifi: rtw88: error codes fix patches



> -----Original Message-----
> From: Zhang Shurong <zhang_shurong@...mail.com>
> Sent: Thursday, April 27, 2023 1:02 AM
> To: Ping-Ke Shih <pkshih@...ltek.com>
> Cc: tony0620emma@...il.com; kvalo@...nel.org; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; linux-wireless@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> Zhang Shurong <zhang_shurong@...mail.com>
> Subject: [PATCH v3 0/2] wifi: rtw88: error codes fix patches
> 
> rtw88 does not handle the failure during copy_from_user or invalid
> user-provided data. We fix such problems by first modifying the return
> value of customized function rtw_debugfs_copy_from_user. Then for all
> the callers rtw_debugfs_set_*, we receive the returned error code.
> Moreover, negative code is returned if the user-provided data is invalid
> instead of a positive value count.
> 
> The changes in this version:
> - check by if (ret) instead of check by if (ret < 0)

It would be better if you preserve the change of v2 as changelog.
v3 is okay to me, so don't need v4 if no other reviewer has comment
for this patchset.

> 
> Zhang Shurong (2):
>   wifi: rtw88: fix incorrect error codes in rtw_debugfs_copy_from_user
>   wifi: rtw88: fix incorrect error codes in rtw_debugfs_set_*
> 
>  drivers/net/wireless/realtek/rtw88/debug.c | 59 ++++++++++++++++------
>  1 file changed, 43 insertions(+), 16 deletions(-)
> 
> --
> 2.40.0
>